Fix ip
binary not being found on some flavors of Linux
#178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This is a fix for an issue reported downstream at GitSquared/edex-ui#227
Changes proposed:
Description (what is this PR about)
Following this issue that I reported back in March, support was added for using
ip
instead ofifconfig
to detect network interfaces on Linux (9d13697, shipped in v3.37.5).However, on some distros,
ip
isn't located at/sbin
, and because of this the library tries to useifconfig
instead, which fails because most of these bleeding-edge systems don't have it available.This PR replaces the
/sbin/ip
file-exists check by acommand -v
one that will succeed ifip
is available in $PATH.