Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling point of interest default info window #1539

Closed
yosigolan opened this issue Nov 11, 2018 · 4 comments
Closed

Allow disabling point of interest default info window #1539

yosigolan opened this issue Nov 11, 2018 · 4 comments

Comments

@yosigolan
Copy link
Contributor

Feature request:
allow disabling point of interest default info window.
this can be done by passing the original google maps event through the api. the event has a stop method that prevents from the info window to appear (see here: https://stackoverflow.com/questions/7478069/disable-point-of-interest-information-window-using-google-maps-api-v3)

this is also related to the issue #691 since it also requires the original event with the place id.
@yosigolan
Copy link
Contributor Author

yosigolan commented Nov 22, 2018 •
edited
Loading

For any one interested, i created a pull request for this. i cant commit it since i dont have permissions. @SebastianM , please update my permissions in order to push the feature.

@yosigolan
Copy link
Contributor Author

@SebastianM can you please give me the permissions to push the branch? am i doing something wrong?

@benjcallaghan
Copy link

@yosigolan I am very interested in this feature, and I would love to see your work included. However, I cannot find your pull request. Can you provide a link to your repository or to the pull request?

yosigolan added a commit to yosigolan/angular-google-maps that referenced this issue Feb 24, 2019
@yosigolan
feat: allow disabling a "point of interest" default info window
b53772a 
allow disabling a "point of interest" default info window.
use it by passing a boolean value to the new property isToShowDefaultInfoWindowForIcons when initializing the map. default value is true.

closes issue sebholstein#1539.
@yosigolan yosigolan mentioned this issue Feb 24, 2019
Closed
LeandroPereiraDaCruz pushed a commit to LeandroPereiraDaCruz/angular-google-maps that referenced this issue Mar 9, 2019
@yosigolan @LeandroPereiraDaCruz
feat: allow disabling a "point of interest" default info window
ff06075 
allow disabling a "point of interest" default info window.
use it by passing a boolean value to the new property isToShowDefaultInfoWindowForIcons when initializing the map. default value is true.

closes issue sebholstein#1539.
@stale
Copy link

stale bot commented May 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 20, 2019
@stale stale bot closed this as completed May 27, 2019
@ghost ghost reopened this May 30, 2019
@stale stale bot removed the stale label May 30, 2019
ghost pushed a commit that referenced this issue Jun 3, 2019
@yosigolan @doom777
feat: Add placeId to map click events
34f651b 
* feat: allow disabling a "point of interest" default info window
* feat: Add placeId to map click events

when clicking on a point of interest on a map the emiting event will include the `placeId` of the location clicked.
allow disabling a "point of interest" default info window. Use it by passing a boolean value to the new property isToShowDefaultInfoWindowForIcons when initializing the map. Default value is `true`.

closes issue #691.
closes issue #1539.
@ghost ghost closed this as completed Jun 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjcallaghan @yosigolan