-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fitBounds breakes protractor tests #1548
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've encountered the same issue, @magnattic did you manage to solve it? |
Nope. we moved away from the library and implemented our own Maps solution. Unfortunately it looks like this project is not being developed much further. Such a shame, it really had promise. Hopefully someone finds the time to pick it up or branch it into something useful. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Fix fitBounds input in map.ts directive causing timeout in protractor tests. _fitBoundsSubscription is now run outside angular ngZone to prevent protractor from waiting for sample and timer rxjs operators to sync map bounds. closes #1548
Issue description
When using `[fitBounds]="true", protractor e2e tests time out.
Current behavior
My protractor tests time out if I add an agm-map with markers and
[fitBounds]="true"
.If I remove
fitBounds
, the tests run fine. This is likely due to somesetTimeout
being run within the ngZone.Any chance this could be solved by using
runOutsideAngular
in the library?The text was updated successfully, but these errors were encountered: