feat(infoWindow): emit event when closed #317
Conversation
|
@alexweber thanks for the PR! |
| @@ -45,6 +45,11 @@ let infoWindowId = 0; | |||
| export class SebmGoogleMapInfoWindow implements OnDestroy, | |||
| OnChanges { | |||
| /** | |||
| * Emits an event when the info window is closed. | |||
| */ | |||
| @Output() infoWindowClosed = new EventEmitter(); | |||
There was a problem hiding this comment.
Event names should be in present tense, so infoWindowClose
There was a problem hiding this comment.
@SebastianM Thanks, done
|
@SebastianM I've ran the code through the formatter and some other files also got picked up, I believe I have this in another PR too but since this is the one you're looking at happy to get it in here. Thanks! |
|
@SebastianM Emitting the info Window itself in this version, we gotta emit a value as far as I know... let me know, thanks! |
| @@ -47,7 +47,7 @@ export class SebmGoogleMapInfoWindow implements OnDestroy, | |||
| /** | |||
| * Emits an event when the info window is closed. | |||
| */ | |||
| @Output() infoWindowClose = new EventEmitter(); | |||
| @Output() infoWindowClose: EventEmitter<SebmGoogleMapInfoWindow> = new EventEmitter(); | |||
There was a problem hiding this comment.
you can use EventEmitter<void> here, so you don't have to emit anything here
|
added one last comment. can you address this comment and squash your commit into one. than im happy to merge it. thanks man! |
|
@alexweber made the changes really quick - it's now merge. thank you |
|
@SebastianM Awesome thanks you beat me to it :) |
initial stab at #306