-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gestureHandling attirbute to MapOptions #919
Conversation
The gestureHandling attribute in MapOptions controls how gestures on the map are handled. The attribute takes one of four string values (cooperative, greedy, none and auto). Changes are not breaking, gestureHandling is an optional attribute and the google maps api defaults this attribute to 'auto'.
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gestureHandling is missing in the inputs
configuration.
* 'none' (The map cannot be panned or zoomed by user gestures.) | ||
* 'auto' [default] (Gesture handling is either cooperative or greedy, depending on whether the page is scrollable or not. | ||
*/ | ||
gestureHandling: string = 'auto'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change it to this for better autocompletion?:
gestureHandling: 'cooperative'|'greedy'|'none'|'auto' = 'auto';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed the comments but I am now getting an issue with the webpack config when running the tests:
> karma start
12 03 2017 14:45:47.938:ERROR [preprocess]: Can not load "webpack"!
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
- configuration.entry should be one of these:
object { <key>: non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function
The entry point(s) of the compilation.
Details:
* configuration.entry should NOT have less than 1 properties ({
"keyword": "minProperties",
"dataPath": ".entry",
"schemaPath": "#/oneOf/0/minProperties",
"params": {
"limit": 1
},
"message": "should NOT have less than 1 properties",
"schema": 1,
"parentSchema": {
"minProperties": 1,
"additionalProperties": {
"oneOf": [
{
"description": "The string is resolved to a module which is loaded upon startup.",
"minLength": 1,
"type": "string"
},
{
"description": "All modules are loaded upon startup. The last one is exported.",
"$ref": "#/definitions/common.nonEmptyArrayOfUniqueStringValues"
}
]
},
"description": "Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.",
"type": "object"
},
"data": {}
}).
object { <key>: non-empty string | [non-empty string] }
Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.
* configuration.entry should be a string.
* configuration.entry should be an array:
[non-empty string]
* configuration.entry should be an instance of function
function returning an entry object or a promise..
at webpack (/Users/jimulle/Desktop/angular2-google-maps/node_modules/webpack/lib/webpack.js:19:9)
at new Plugin (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma-webpack/lib/karma-webpack.js:63:18)
at invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:75:15)
at Array.instantiate (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:59:20)
at get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
at /Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:71:14
at Array.map (native)
at Array.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:70:31)
at Injector.get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
at instantiatePreprocessor (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/preprocessor.js:55:20)
at Array.forEach (native)
at createPreprocessor (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/preprocessor.js:74:20)
at Array.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:75:15)
at get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
at /Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:71:14
at Array.map (native)
at Injector.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:70:31)
at Server.start (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/server.js:103:18)
at Object.exports.run (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/cli.js:280:26)
at Object.<anonymous> (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/bin/karma:3:23)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
START:
12 03 2017 14:45:47.974:INFO [karma]: Karma v1.3.0 server started at http://localhost:9876/
12 03 2017 14:45:47.975:INFO [launcher]: Launching browser Chrome with unlimited concurrency
12 03 2017 14:45:47.976:ERROR [karma]: Found 1 load error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimulle thx! Can you address the comments? |
@jimulle the build process is now fixed. I will try to make the changes and merge your PR |
I will rebase and update the PR tonight |
@jimulle I've done it for you 😃 changed some little details but your contribution remains. |
thx for your time! |
The gestureHandling attribute in MapOptions controls how gestures on the map are handled. The attribute takes one of four string values (cooperative, greedy, none and auto). Changes are not breaking, gestureHandling is an optional attribute and the google maps api defaults this attribute to 'auto'. Closes sebholstein#919
The gestureHandling attribute in MapOptions controls how
gestures on the map are handled. The attribute takes one
of four string values (cooperative, greedy, none and auto).
Changes are not breaking, gestureHandling is an optional
attribute and the google maps api defaults this attribute to
'auto'.