Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't open the popup with bookmarklet #64

Closed
nicosomb opened this issue Mar 28, 2013 · 4 comments
Closed

Don't open the popup with bookmarklet #64

nicosomb opened this issue Mar 28, 2013 · 4 comments
Labels
enhancement

Comments

@nicosomb
Copy link

Hello sebsauvage !
Is there any way to not open the popup when I use the bookmarklet ?

I want that a link is automatically added to my shaarli without confirmation in the popup.

Nicolas
@sebsauvage
Copy link
Owner

This is a good idea. Let's call it "TL;DR" bookmarklet.
It will records the URL in Shaarli in private mode without confirmation. I will possibly ass visual feedback (maybe in current page).

@nicosomb
Copy link
Author

Great.
In fact, I want to use Shaarli like a Read-it-later system : all my private links are my "read it later" links.

@sebsauvage
Copy link
Owner

Technical note (for me): As there will be no form validation from the user and posting will be done with a GET request, the bookmarklet must contain a token unique to the Shaarli installation to prevent spamming of the Shaarli using XSRF.

@tontof
Copy link

tontof commented Mar 29, 2013

Just because it's in nicosomb's article, why not adding to #33 the possibility to add tags in GET query ? For this TL;DR bookmarklet, it will be possible to add a specific tag and it will be easier to find article to read later.

pikzen pushed a commit to pikzen/Shaarli that referenced this issue Jan 21, 2015
@ArthurHoaro
W3C compliance (work on issue sebsauvage#64 - shaarli#64):
8079dfd 
  * fix duplicate IDs - #paging_older, #paging_newer become classes as the paging is displayed twice (top, bottom) in the linklist
  * fix duplicate IDs - #paging_privatelinks and #paging_linksperpage become classes
  * daily links are now valid (use &amp)
  * name attribute is not used anymore on a tag in link list
  * center tag is replaced by CSS in picwall and tag cloud
  * action in form tag can't be empty, use # instead
  * fixed configure table with CSS instead of cellpadding, border, and valign
  * export links are now valid
  * remove "size" in input tag
  * Fix missing alt attributes for img elements
  * tpl/daily: Use HTML entities instead of char escape codes
  * tpl/export: fix missing </span> closing tag
  * Remove obsolete language attribute on <script> elements
pikzen pushed a commit to pikzen/Shaarli that referenced this issue Jan 21, 2015
@nodiscc
Merge pull request sebsauvage#77 from ArthurHoaro/w3c
a2d5ef2 
Make Shaarli's template W3C compliant sebsauvage#64
pikzen pushed a commit to pikzen/Shaarli that referenced this issue Jan 21, 2015
@ArthurHoaro @pikzen
W3C compliance (work on issue sebsauvage#64 - shaarli#64):
3b8b2e6 
  * fix duplicate IDs - #paging_older, #paging_newer become classes as the paging is displayed twice (top, bottom) in the linklist
  * fix duplicate IDs - #paging_privatelinks and #paging_linksperpage become classes
  * daily links are now valid (use &amp)
  * name attribute is not used anymore on a tag in link list
  * center tag is replaced by CSS in picwall and tag cloud
  * action in form tag can't be empty, use # instead
  * fixed configure table with CSS instead of cellpadding, border, and valign
  * export links are now valid
  * remove "size" in input tag
  * Fix missing alt attributes for img elements
  * tpl/daily: Use HTML entities instead of char escape codes
  * tpl/export: fix missing </span> closing tag
  * Remove obsolete language attribute on <script> elements
pikzen pushed a commit to pikzen/Shaarli that referenced this issue Jan 27, 2015
@virtualtam
w3c: fix HTML syntax errors
04751e0 
Fixes sebsauvage#64

All pages:
- add `urlencode` when passing the version to a custom stylesheet;
- set meaningful values of `alt` and `title` for QR-Code images.

Install page:
- the form's `action` attribute must be non-empty;
- the `valign` attribute is deprecated.

Signed-off-by: VirtualTam <virtualtam@flibidi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicosomb @sebsauvage @tontof