allow setting custom thumbnails #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repository is inactive. Please refer to https://github.com/shaarli/Shaarli for enhancements. Also note that there is an ongoing work with thumbnails: shaarli#153 |
|
Pull request reopened as shaarli#361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello Seb,
this patch adds a field in the "edit link" page to allow setting a custom thumbnail for the link. If no address is provided, but behavior remains as before. If a link is provided, the thumbnail is generated with the existing functions.
The use-case is for creating a personal "virtual library" based on Shaarli, with a link to the book page and its cover as thumbnail.