Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: add the SCMP_FLTATR_CTL_WAITKILL filter attribute #391

Closed
wants to merge 1 commit into from

Conversation

pcmoore
Copy link
Member

@pcmoore pcmoore commented Sep 22, 2022

The SCMP_FLTATR_CTL_WAITKILL attribute requests that the SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag be passed to the seccomp(2) system call when possible, which is currently only when the SECCOMP_FILTER_FLAG_NEW_LISTENER flag is also set.

Resolves #387

@pcmoore pcmoore self-assigned this Sep 22, 2022
@pcmoore pcmoore added this to the v2.6.0 milestone Sep 22, 2022
@coveralls
Copy link

coveralls commented Sep 22, 2022

Coverage Status

Coverage increased (+0.03%) to 89.71% when pulling 1bcbe5d on pcmoore:gh-387 into e797591 on seccomp:main.

@pcmoore
Copy link
Member Author

pcmoore commented Sep 22, 2022

Hold off on reviewing/ACK'ing this PR, I had a thought this morning that we might also need to bump the API level for this; I'll check that and update this PR later today (hopefully).

The SCMP_FLTATR_CTL_WAITKILL attribute requests that the
SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag be passed to the
seccomp(2) system call when possible, which is currently only when
the SECCOMP_FILTER_FLAG_NEW_LISTENER flag is also set.

Signed-off-by: Paul Moore <paul@paul-moore.com>
@pcmoore
Copy link
Member Author

pcmoore commented Sep 22, 2022

Okay, fixed. I added API level 7 to match with the new flag.

Copy link
Member

@drakenclimber drakenclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

@drakenclimber
Copy link
Member

Thanks, @pcmoore

@drakenclimber
Copy link
Member

Pushed to main in commit 9698996. Thanks, @pcmoore

@pcmoore
Copy link
Member Author

pcmoore commented Nov 5, 2022

Thanks @drakenclimber, I've had limited network access the past few weeks but things should be getting back to normal next week ... once I get caught up ;)

@drakenclimber
Copy link
Member

Thanks @drakenclimber, I've had limited network access the past few weeks but things should be getting back to normal next week ... once I get caught up ;)

@pcmoore, No worries. Let me know if you need any help or there's anything you want me to pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: add support for SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV (Linux 5.19)
3 participants