-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: add the SCMP_FLTATR_CTL_WAITKILL filter attribute #391
Conversation
Hold off on reviewing/ACK'ing this PR, I had a thought this morning that we might also need to bump the API level for this; I'll check that and update this PR later today (hopefully). |
The SCMP_FLTATR_CTL_WAITKILL attribute requests that the SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag be passed to the seccomp(2) system call when possible, which is currently only when the SECCOMP_FILTER_FLAG_NEW_LISTENER flag is also set. Signed-off-by: Paul Moore <paul@paul-moore.com>
Okay, fixed. I added API level 7 to match with the new flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Acked-by: Tom Hromatka <tom.hromatka@oracle.com>
Thanks, @pcmoore |
Thanks @drakenclimber, I've had limited network access the past few weeks but things should be getting back to normal next week ... once I get caught up ;) |
@pcmoore, No worries. Let me know if you need any help or there's anything you want me to pick up. |
The SCMP_FLTATR_CTL_WAITKILL attribute requests that the SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV flag be passed to the seccomp(2) system call when possible, which is currently only when the SECCOMP_FILTER_FLAG_NEW_LISTENER flag is also set.
Resolves #387