Scapy terminal improvements #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4073 +/- ##
==========================================
+ Coverage 81.58% 81.95% +0.36%
==========================================
Files 327 328 +1
Lines 75546 75836 +290
==========================================
+ Hits 61633 62148 +515
+ Misses 13913 13688 -225
|
This commit changes the following: - .scapy_startup.py and .scapy_prestart.py are moved to .config/scapy/startup.py and .config/scapy/prestart.py - the Scapy terminal now supports ptpython and bpython, in addition to the existing IPython
|
@gpotter2 I am fine with moving everything into |
guedou
reviewed
Jul 21, 2023
guedou
previously requested changes
Jul 21, 2023
|
@guedou @polybassa @p-l- Ready for review & merge ! |
|
LGTM.Thanks for the changes. I don't why but I cannot approve the PR. |
polybassa
approved these changes
Jul 31, 2023
p-l-
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the following:
.scapy_startup.pyand.scapy_prestart.pyare moved to.config/scapy/startup.pyand.config/scapy/prestart.py. This is what apparently most big libraries/softwares are moving towards (matplotlib, wireshark, etc.).Question: do we want to move the history there? (for now it's the only file remaining in ~)(done).config/scapy/prestart.py. This is IMHO much easier for a novice user to understand what's going on, since it will show what it is supposed to look like.ptpythonandbpython, in addition to the existingIPython.ptpythoncomes with theptipythonvariant that's a mix betweenptpythonandIPython.usage.rst.Bugs:
repris also brokenI encourage you to try them all a bit, some are pretty fun. Until one of them is as stable as IPython though, it will remain the default. There are some
conf.color_themefeatures that comes with IPython that are not implemented here yet.Gallery
bpython
ptpython
