DNS: add Extended DNS Error EDNS0 Option #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
+ Coverage 80.97% 81.75% +0.78%
==========================================
Files 330 330
Lines 76239 76245 +6
==========================================
+ Hits 61732 62333 +601
+ Misses 14507 13912 -595
|
evverx
force-pushed
the
extended-dns-errors
branch
from
902f26d to
67f281a
Compare
p-l-
approved these changes
Oct 2, 2023
evverx
commented
Oct 2, 2023
evverx
force-pushed
the
extended-dns-errors
branch
from
67f281a to
d4446c3
Compare
https://www.rfc-editor.org/rfc/rfc8914.html The patch was also cross-checked with Wireshark: ``` Option: Extended DNS Error Option Code: Extended DNS Error (15) Option Length: 45 Option Data: 000670726f6f66206f66206e6f6e2d6578697374656e6365206f66206578616d706c652e… Info Code: DNSSEC Bogus (6) Extra Text: proof of non-existence of example.com. NSEC ```
evverx
force-pushed
the
extended-dns-errors
branch
from
d4446c3 to
a5c621e
Compare
|
I rebased this PR on top of 619d1e4 and force-pushed it to trigger the CI. Looks like it's green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rfc-editor.org/rfc/rfc8914.html
The patch was also cross-checked with Wireshark: