Add support for S1G beacon to the dot11 layer. (#2) #4458
Conversation
- Includes unit test parsing and confirming an S1G beacon - Includes support for the new Frame Control format for type=3, subtype=1 (S1G beacon) - Includes changes to support addressing used in S1G beacon. All dot11 unit tests pass with this change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4458 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 355 355
Lines 84830 84835 +5
=======================================
+ Hits 69287 69292 +5
Misses 15543 15543
|
|
I'm really not sure what to do here as the commit into my master branch shows coverage at the correct level (80.73%). I don't know why coverage is reported so low here. https://app.codecov.io/github/rkinder2023/scapy-s1g/commit/d377b137fa67845896442fd01615abcd883bc590 Any hints from the maintainers? |
* Add support for S1G beacon to the dot11 layer. - Includes unit test parsing and confirming an S1G beacon - Includes support for the new Frame Control format for type=3, subtype=1 (S1G beacon) - Includes changes to support addressing used in S1G beacon. All dot11 unit tests pass with this change.
* Fix review comments from @p-l-: - Use set for 'type in' checks for extension frame type 3, subtype 1 (S1G beacon). * Update to FCfield to split into three parts for type 3, subtype 1 (S1G beacon frame control field). This allows use of BitField for the 'bw', and FlagsField for the remaining bits.
|
Could I please get another review? I have modified to use a set on the 'type in' as per @p-l-, and updated the frame control field to split into three sections for type 3, subtype 1 (@p-l-, @gpotter2 suggestions). This seems the best solution as a change to the underlying frame control to use BitField for all types and subtypes will introduce significant back-compat issues. Let me know if there is any more testing/unit testing you'd like on this change? I'd like to push this one in as I have more changes to support the S1G IEs within the beacon queued up. Thanks guys! |
|
Yeah sorry for the delay. I wanted to test your PR, and still couldn't get around to do it. |
|
@gpotter2, PCAP parsing for the trace I have doesn't work, I'm working on an acceptable solution to this. I managed to hack something in place in order to extract this beacon frame, but don't yet have something ready for review. |
|
This is the S1G beacon I used for developing the patch. The hack I used to get the pcap to load is here: I'm sure there's a better way to make TLVs work properly, but I'm not sure what it is. |
|
@gpotter2, any thoughts on this? Anything else you need me to provide? |
Add support for 802.11ah (S1G) beacon parsing.
All dot11 unit tests pass with this change.
Fixes #4439