Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle release tag formats in _parse_tag() #4548

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

dhgutteridge
Copy link
Contributor

Also accommodate formal release tags, so the generated version is
correct for downstream packagers.

Also accommodate formal release tags, so the generated version is
correct for downstream packagers.
@dhgutteridge dhgutteridge mentioned this pull request Oct 1, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (79974f2) to head (9636928).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4548      +/-   ##
==========================================
- Coverage   81.60%   81.60%   -0.01%     
==========================================
  Files         356      356              
  Lines       85533    85536       +3     
==========================================
- Hits        69802    69801       -1     
- Misses      15731    15735       +4     
Files with missing lines Coverage Δ
scapy/__init__.py 83.11% <75.00%> (-0.67%) ⬇️

... and 4 files with indirect coverage changes

@gpotter2
Copy link
Member

gpotter2 commented Oct 2, 2024

Looks good. Thanks for the PR !

@gpotter2 gpotter2 merged commit 87b6e26 into secdev:master Oct 2, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants