[CodeGen] separate functions of ABICodec and ExprEmitter

second-state · Jun 11, 2021 · aa330a8 · aa330a8
1 parent ae79ef5
commit aa330a8
Show file tree

Hide file tree

Showing 13 changed files with 1,392 additions and 1,325 deletions.
diff --git a/include/soll/AST/Type.h b/include/soll/AST/Type.h
@@ -496,8 +496,8 @@ class TupleType : public Type {
   }
   size_t getStoragePos(size_t ElementIndex) const {
     size_t Pos = 0;
-    for (size_t i = 0; i < ElementIndex; ++i) {
-      Pos += ElementTypes[i]->getStorageSize() / 32;
+    for (size_t I = 0; I < ElementIndex; ++I) {
+      Pos += ElementTypes[I]->getStorageSize() / 32;
     }
     return Pos;
   }
@@ -549,13 +549,13 @@ class StructType : public TupleType {
   }
   llvm::Type *getLLVMType() const { return Tp; }
   size_t getElementIndex(std::string Name) const {
-    size_t i = 0;
-    for (; i < ElementNames.size(); ++i) {
-      if (ElementNames[i] == Name) {
+    size_t I = 0;
+    for (; I < ElementNames.size(); ++I) {
+      if (ElementNames[I] == Name) {
         break;
       }
     }
-    return i;
+    return I;
   }
   bool hasElement(std::string Name) const {
     return getElementIndex(Name) < ElementNames.size();

diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp
@@ -270,7 +270,7 @@ FunctionDecl::FunctionDecl(
                       IsVirtual, std::move(Overrides)),
       SM(SM), IsConstructor(IsConstructor), IsFallback(IsFallback),
       FunctionModifiers(std::move(Modifiers)), Body(std::move(Body)) {
-  // TODO
+
   std::vector<std::reference_wrapper<const TypePtr>> PTys;
   std::vector<std::reference_wrapper<const TypePtr>> RTys;
   auto PNames = std::make_shared<std::vector<std::string>>();

diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp
@@ -75,8 +75,8 @@ std::vector<Expr *> CallExpr::getArguments() {
       ParamNamesIndex[ParamName] = ParamSize++;
     }
     Args.resize(ParamSize);
-    for (size_t i = 0; i < ParamSize; ++i) {
-      Args[ParamNamesIndex.at(Names->at(i))] = Arguments.at(i).get();
+    for (size_t I = 0; I < ParamSize; ++I) {
+      Args[ParamNamesIndex.at(Names->at(I))] = Arguments.at(I).get();
     }
   } else {
     for (auto &Arg : Arguments)
@@ -95,8 +95,8 @@ std::vector<const Expr *> CallExpr::getArguments() const {
       ParamNamesIndex[ParamName] = ParamSize++;
     }
     Args.resize(ParamSize);
-    for (size_t i = 0; i < ParamSize; ++i) {
-      Args[ParamNamesIndex.at(Names->at(i))] = Arguments.at(i).get();
+    for (size_t I = 0; I < ParamSize; ++I) {
+      Args[ParamNamesIndex.at(Names->at(I))] = Arguments.at(I).get();
     }
   } else {
     for (auto &Arg : Arguments)

diff --git a/lib/AST/StmtVisitor.cpp b/lib/AST/StmtVisitor.cpp
@@ -164,8 +164,8 @@ template <bool Const> void StmtVisitorBase<Const>::visit(AsmIdentifierType &) {
 
 template <bool Const>
 void StmtVisitorBase<Const>::visit(AsmIdentifierListType &L) {
-  for (auto i : L.getIdentifiers())
-    i->accept(*this);
+  for (auto I : L.getIdentifiers())
+    I->accept(*this);
 }
 
 } // namespace soll

diff --git a/lib/Basic/Diagnostic.cpp b/lib/Basic/Diagnostic.cpp
@@ -270,9 +270,9 @@ void Diagnostic::FormatDiagnostic(const char *DiagStr, const char *DiagEnd,
   llvm::SmallVector<intptr_t, 2> QualTypeVals;
   llvm::SmallVector<char, 64> Tree;
 
-  for (unsigned i = 0, e = getNumArgs(); i < e; ++i)
-    if (getArgKind(i) == DiagnosticsEngine::ArgumentKind::ak_qualtype)
-      QualTypeVals.push_back(getRawArg(i));
+  for (unsigned I = 0, e = getNumArgs(); I < e; ++I)
+    if (getArgKind(I) == DiagnosticsEngine::ArgumentKind::ak_qualtype)
+      QualTypeVals.push_back(getRawArg(I));
 
   while (DiagStr != DiagEnd) {
     if (DiagStr[0] != '%') {