Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSCP]使用SPU实现随机森林算法 #792

Merged
merged 11 commits into from
Aug 1, 2024
Merged

[OSCP]使用SPU实现随机森林算法 #792

merged 11 commits into from
Aug 1, 2024

Conversation

xbw886
Copy link
Contributor

@xbw886 xbw886 commented Jul 29, 2024

fixed : #254

@deadlywing deadlywing self-requested a review July 29, 2024 08:07
deadlywing
deadlywing reviewed Jul 31, 2024
View reviewed changes
sml/ensemble/emulations/forest_emul.py Outdated Show resolved Hide resolved
sml/ensemble/BUILD.bazel Show resolved Hide resolved
sml/ensemble/emulations/BUILD.bazel Outdated Show resolved Hide resolved
sml/tree/BUILD.bazel Outdated Show resolved Hide resolved
sml/ensemble/tests/BUILD.bazel Outdated Show resolved Hide resolved
sml/ensemble/forest.py Outdated Show resolved Hide resolved
sml/ensemble/forest.py Outdated Show resolved Hide resolved
sml/ensemble/forest.py Outdated Show resolved Hide resolved
sml/ensemble/emulations/forest_emul.py Outdated Show resolved Hide resolved
sml/tree/tree.py Outdated Show resolved Hide resolved
@deadlywing
Copy link
Contributor

另外，，bazel 文件 和python文件也需要格式化，，
参考：https://github.com/secretflow/spu/blob/main/sml/development.md#before-pull-request

deadlywing
deadlywing reviewed Aug 1, 2024
View reviewed changes
sml/ensemble/forest.py Outdated Show resolved Hide resolved
sml/ensemble/forest.py Outdated Show resolved Hide resolved
sml/ensemble/forest.py Outdated Show resolved Hide resolved
deadlywing
deadlywing approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@deadlywing deadlywing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadlywing deadlywing merged commit 854f3ef into secretflow:main Aug 1, 2024
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deadlywing deadlywing deadlywing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用 SPU 实现随机森林算法
2 participants
@xbw886 @deadlywing