Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added descriptions to TaintConfigSchema.json to explain its semantics #644

Conversation

StamesJames
Copy link
Contributor

I started playing around with phasar a bit to look if I can use it on llvm code created by rust. At first I have used the analysis-config wrong so I wrote some descriptions into the schema. Maybe this can help future users too and I hope my descriptions are right.

@MMory
Copy link
Member

MMory commented Jul 25, 2023

Hi @StamesJames , thank you for your contribution. I have committed a minor change, making all the first letters of the description text capitals. Do you agree with that? If so, I'll merge.

@StamesJames
Copy link
Contributor Author

Sounds good, thanks :-)
I also wrote some notes while playing around with PhASAR which almost are tutorials for using the basics of phasar-cli. I could contribute those too but if I understand it right I can't make a pullrequest for the wiki repo where your other tutorials are. should I just put them in an issue?

@MMory
Copy link
Member

MMory commented Jul 26, 2023

Would be good to have those tutorials, thank you! Yeah, an issue might be the best way.

Regarding this PR, the parentheses in line 22 break the build, I have not found an obvious way to escape them, maybe omitting them is the best way to go forward.

@MMory MMory merged commit 907d01d into secure-software-engineering:development Jul 26, 2023
4 checks passed
@StamesJames
Copy link
Contributor Author

ah ok thanks for fixing this.
And I will write the tutorial and put in in an Issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants