Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug-libdeps in CI #706

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Fix debug-libdeps in CI #706

merged 10 commits into from
Mar 25, 2024

Conversation

fabianbs96
Copy link
Member

The flag PHASAR_DEBUG_LIBDEPS ignored dependency issues arising from debug-only code, such as assert.

@fabianbs96 fabianbs96 added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 4, 2024
@fabianbs96 fabianbs96 self-assigned this Mar 4, 2024
@fabianbs96 fabianbs96 requested a review from MMory as a code owner March 4, 2024 17:04
MMory
MMory approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@MMory MMory merged commit 5c037c2 into development Mar 25, 2024
5 checks passed
@MMory MMory deleted the f-FixDebugLibdepsCI branch March 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianbs96 @MMory