Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully specify all fields within signatures #11

Merged
merged 7 commits into from
Dec 14, 2020
Merged

Fully specify all fields within signatures #11

merged 7 commits into from
Dec 14, 2020

Conversation

MarkLodato
Copy link
Collaborator

Closes #4.

@MarkLodato
Define "keyid" field.
68ec423 
Now all fields are fully defined.
@MarkLodato
Explain multiple signatures.
3f05225 
Also remove the ellipsis (…) from the JSON so that it renders correctly
on GitHub.
@MarkLodato
Fix keyid for backwards compatible signatures.
fc56b2b
@MarkLodato
Split Definitions into Parameters and Functions
04fc5ce
@MarkLodato MarkLodato mentioned this pull request Dec 8, 2020
Merged
joshuagl
joshuagl reviewed Dec 10, 2020
View reviewed changes
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Show resolved Hide resolved
@joshuagl joshuagl mentioned this pull request Dec 10, 2020
Merged
@MarkLodato
Use RFC 2119 language consistently.
e2e1d84 
Always use MUST/SHOULD in caps with bold, and avoid those terms outside
their RFC 2119 meaning.
@MarkLodato
Expand the explanation of KEYID.
d05e7b4
joshuagl
joshuagl approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammatical nit, but otherwise this looks great. Thanks!

specification.md Outdated Show resolved Hide resolved
@MarkLodato @joshuagl
Fix typo: remove extra "be"
db5ffd1 
Co-authored-by: Joshua Lock <jlock@vmware.com>
adityasaky
adityasaky approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@adityasaky adityasaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MarkLodato!

@adityasaky adityasaky merged commit e6ae241 into secure-systems-lab:master Dec 14, 2020
@MarkLodato MarkLodato deleted the multi-signature branch December 14, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasaky adityasaky adityasaky approved these changes

@joshuagl joshuagl joshuagl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify the other fields of signature
3 participants
@MarkLodato @adityasaky @joshuagl