Fully specify all fields within signatures
#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all fields are fully defined.
Also remove the ellipsis (…) from the JSON so that it renders correctly on GitHub.
joshuagl
reviewed
Dec 10, 2020
Always use MUST/SHOULD in caps with bold, and avoid those terms outside their RFC 2119 meaning.
joshuagl
approved these changes
Dec 11, 2020
Collaborator
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
Minor grammatical nit, but otherwise this looks great. Thanks!
Co-authored-by: Joshua Lock <jlock@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4.