Fully specify all encodings. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Specify that payload type is encoded as UTF-8 when passed to PAE. Previously this was ambiguous since PAYLOAD_TYPE was a unicode string while the `type` parameter of PAE() required a byte sequence. * Clarify that SERIALIZED_BODY is a byte sequence. * Spell out what Sign(), UTF8(), and Base64() are. Closes secure-systems-lab#3.
joshuagl
approved these changes
Dec 3, 2020
adityasaky
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that payload type is encoded as UTF-8 when passed to PAE. Previously this was ambiguous since PAYLOAD_TYPE was a unicode string while the
typeparameter of PAE() required a byte sequence.Clarify that SERIALIZED_BODY is a byte sequence.
Spell out what Sign(), UTF8(), and Base64() are.
Closes #3.
NOTE: For Sign(), this PR simply documents the current state, which is that we do not yet have opinions on the signature algorithm, format, or key management. We may we want to be more opinionated in the future - that is still under discussion (but out of scope of this PR.)