Add hash algorithm transition plan #76
Conversation
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
This looks solid. Only one minor comment/suggestion.
brainwane
left a comment
brainwane
left a comment
There was a problem hiding this comment.
1 tiny typofix -- otherwise looks good to me.
pep-0458.txt
Outdated
| However, once support for an old algorithm is turned off, clients that don't | ||
| support the new algorithm will only be able to install or update packages, | ||
| including the client itself, by disabling TUF verification. To allow clients to | ||
| transition without temporarily loosing TUF security guarantees, we recommend |
There was a problem hiding this comment.
Well spotted. Thanks! Fixed and force-pushed.
lukpueh
force-pushed
the
hash-algo-transition
branch
from
d9bfddd to
8872dfd
Compare
|
Now that python#1203 is merged, we can't piggyback into upstream on the @trishankatdatadog, did you still want to leave a comment about referencing the newly added section somewhere else in the pep? |
trishankatdatadog
left a comment
trishankatdatadog
left a comment
There was a problem hiding this comment.
Thanks, @lukpueh. Please address these few concerns, and let's open a new PR on upstream, please.
pep-0458.txt
Outdated
|
|
||
| 1. Implement new algorithm in Warehouse. | ||
|
|
||
| 2. Re-generate existing TUF metadata to include both old and new algorithm |
There was a problem hiding this comment.
I would rewrite this sentence to say something like: "Regenerate existing, unexpired to include hashes using both the old and new algorithms. All new metadata going forward shall list both hash algorithms."
pep-0458.txt
Outdated
| metadata needs to be renewed, that is *bin-n*, *snapshot* and *timestamp*. | ||
| Thus, only online keys are required to sign renewed metadata. | ||
|
|
||
| 3. Announce transition on high-visibility channels. |
There was a problem hiding this comment.
Such as? The Python Discourse?
Add subsection to section "Managing Future Changes to the Update Process" that explains how to transition from an old (weak) to a new (stronger) hashing algorithm without disrupting client workflows.
lukpueh
force-pushed
the
hash-algo-transition
branch
from
8872dfd to
47e0ced
Compare
|
Thanks for the suggestions, @trishankatdatadog, I amended my last commit to integrate them and will open a new PR to upstream. |
|
Superseded by python#1253. Closing here. |
4 participants
Picks up discussion from #68
Add subsection to section "Managing Future Changes to the Update Process" that explains how to transition from an old (weak) to a new (stronger) hashing algorithm without disrupting client workflows.