Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundary between securesystemslib and TUF is off. #161

Closed
awwad opened this issue Dec 14, 2018 · 4 comments
Closed

Boundary between securesystemslib and TUF is off. #161

awwad opened this issue Dec 14, 2018 · 4 comments

Comments

@awwad
Copy link
Contributor

awwad commented Dec 14, 2018

Some of the functions in securesystemslib are really pieces of TUF that I don't think are of use to others and don't belong here.

Some examples that IIUC don't belong in securesystemslib:

  • util.ensure_all_targets_allowed(rolename, list_of_targets, parent_delegations)
  • util.find_delegated_role(roles, delegated_role)
  • formats.NUMBINS_SCHEMA
  • formats.TARGETS_SCHEMA
  • formats.SNAPSHOT_SCHEMA
  • formats.TIMESTAMP_SCHEMA
  • formats.ROOT_SCHEMA
  • formats.MIRRORDICT_SCHEMA
  • formats.MIRRORLIST_SCHEMA

Other functions that could conceivably be useful in general have zero context within the module:

  • util.paths_are_consistent_with_hash_prefixes(paths, path_hash_prefixes)
  • formats.PROJECT_CFG_SCHEMA

Things I'm less sure about:

  • formats.THRESHOLD_SCHEMA
  • exceptions.RoleAlreadyExistsError
  • exceptions.UnknownRoleError
  • formats.ROLENAME_SCHEMA
@JustinCappos
Copy link

The general concept makes sense to me.

@lukpueh
Copy link
Member

lukpueh commented Jan 10, 2019

We have some utility functions implemented in in-toto that might be a good fit for securesystemslib (see in-toto/in-toto#80).

@lukpueh
Copy link
Member

lukpueh commented Jan 10, 2019

IMHO #35 and #75 are also related to this issue.

@awwad awwad mentioned this issue Jan 10, 2019
Merged
3 tasks
awwad added a commit that referenced this issue Apr 3, 2019
@awwad
Removes TUF-specific formats from formats.py
406e05f 
Largely resolves Issue #161, especially given the merge of
PR #162.

See GitHub:
#161
#162

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
@awwad awwad mentioned this issue Apr 3, 2019
Merged
lukpueh pushed a commit that referenced this issue Sep 4, 2019
@awwad @lukpueh
Removes TUF-specific formats from formats.py
0cfe418 
Largely resolves Issue #161, especially given the merge of
PR #162.

See GitHub:
#161
#162

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
@lukpueh
Copy link
Member

lukpueh commented Sep 6, 2019

Fixed with #165

@lukpueh lukpueh closed this as completed Sep 6, 2019
tanishqjasoria pushed a commit to tanishqjasoria/securesystemslib that referenced this issue Jan 30, 2020
@awwad @tanishqjasoria
Removes TUF-specific formats from formats.py
e0b9849 
Largely resolves Issue secure-systems-lab#161, especially given the merge of
PR secure-systems-lab#162.

See GitHub:
secure-systems-lab#161
secure-systems-lab#162

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukpueh @JustinCappos @awwad