Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better distinguish between keytype and scheme for ECDSA keys #239

Closed
adityasaky opened this issue May 28, 2020 · 2 comments
Closed

Better distinguish between keytype and scheme for ECDSA keys #239

adityasaky opened this issue May 28, 2020 · 2 comments

Comments

@adityasaky
Copy link
Member

Description of issue or feature request:

The key format provided by securesystemslib defines a keytype field and a scheme field. Currently, there is no distinction between these fields for ECDSA keys.

Current behavior:

ECDSA keys have the following format:

{
    "keytype" : "ecdsa-sha2-nistp256",
    "scheme" : "ecdsa-sha2-nistp256",
    "keyval" : {"public" : PUBLIC}
}

As noted in 761aded, ecdsa-sha2-nistp384 is also supported by securesystemslib.

Expected behavior:

Update securesystemslib to use just ecdsa as keytype while retaining the current scheme formats. This also aligns with the key format for RSA keys where we have:

{
    "keytype" : "rsa",
    "scheme" : "rsassa-pss-sha256",
    "keyval" : {"public" : PUBLIC}
}
@shibumi
Copy link

shibumi commented Aug 14, 2020

Good work, I just want to mention, that in in-toto-golang we currently follow the expected behavior:

{
    "keytype" : "ecdsa",
    "scheme" : "ecdsa-sha2-nistp256",
    "keyval" : {"public" : PUBLIC}
}

@lukpueh
Copy link
Member

lukpueh commented Aug 20, 2020

Closed by #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants