Update key types #28
Merged
Update key types #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Saky <aditya@saky.in>
adityasaky
force-pushed
the
update-key-types
branch
from
eb724c8
to
51fe93f
Compare
|
Thanks! I think we should be also moving to tagging the spec as 1.0... |
lukpueh
reviewed
May 27, 2020
There was a problem hiding this comment.
Thanks for the PR @adityasaky. The change makes sense, but it doesn't fully represent the current implementation...
|
To summarize in the main thread, @lukpueh pointed out that a change I made to the ECDSA key format doesn't match the current reality. As it stands, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates section 4.2 of the in-toto spec to reflect changes to the key types and formats. Also fixes #21.