Skip to content

[gpg] Fix return code check #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

[gpg] Fix return code check #203

merged 1 commit into from
Jan 30, 2020

Conversation

@ofek
Copy link
Contributor

@ofek ofek commented Jan 30, 2020

On Python 3.8:

SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if process.returncode is not 0:

@coveralls
Copy link

coveralls commented Jan 30, 2020

Coverage Status

Coverage remained the same at ?% when pulling 73fedd0 on ofek:patch-1 into 1dbf547 on secure-systems-lab:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 30, 2020

Coverage Status

Coverage remained the same at ?% when pulling 73fedd0 on ofek:patch-1 into 1dbf547 on secure-systems-lab:master.

@lukpueh lukpueh merged commit 992a944 into secure-systems-lab:master Jan 30, 2020
@ofek ofek deleted the patch-1 branch January 30, 2020 15:25
@lukpueh lukpueh mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukpueh lukpueh lukpueh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ofek @coveralls @lukpueh