Change DSA test key format + adopt test code #264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Related #261, #251
Description of the changes being introduced by the pull request:
A recent pyca/cryptography update dropped support for DSA ssh public keys with bit size other than 1024, which broke our tests. See pyca/cryptography#5373.
This PR changes the test key format to X.509 SubjectPublicKeyInfo PEM and updates the corresponding test code.
Note: ssh-keygen mistakingly calls the format pkcs8 although it is X.509 SubjectPublicKeyInfo PEM.
Please verify and check that the pull request fulfils the following
requirements: