Skip to content

Conversation

@jku
Copy link
Collaborator

@jku jku commented Feb 10, 2021

Description of the changes being introduced by the pull request:

Because of recent issues with travis I ended up polishing my Github CI commit a bit:

  • tests enabled on linux and mac
  • windows is disabled due to gpg hanging and a storage test failure: these need to be investigated
  • The no-gpg cases are now handled using the new environment variable
  • No coveralls support

@jku
Copy link
Collaborator Author

jku commented Feb 10, 2021

The Windows gpg failures look like this

TimeoutExpired: Command '['gpg', '--detach-sign', '--digest-algo', 'SHA256', '--homedir', 'c:/users/runner~1/appdata/local/temp/tmprxgwki/rsa']' timed out after 3 seconds

And the storage test failure:

======================================================================
FAIL: test_exceptions (tests.test_storage.TestStorage)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\securesystemslib\securesystemslib\tests\test_storage.py", line 66, in test_exceptions
    self.storage_backend.create_folder, '/none/existent/path')
 AssertionError: StorageError not raised

@coveralls
Copy link

coveralls commented Feb 10, 2021

Coverage Status

Coverage remained the same at 98.531% when pulling 3c7f65d on jku:gh-actions into dff4425 on secure-systems-lab:master.

@jku jku requested a review from lukpueh February 10, 2021 13:43
Jussi Kukkonen added 2 commits February 10, 2021 17:52
Windows is disabled since there are multiple failures currently.

The special cases (purepy27, purepy38, py27-no-gpg, py38-no-gpg) are not
handled.

Coveralls is not integrated.
Use the recently added GNUPG env variable to hide gpg.
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the workflow file, @jku! It looks quite good to me. We should ticketize the remaining tasks i.e.:

  • reinstate coveralls
  • enable windows builds

I can do that if you want.

I also suggest to remove .travis.yml and all traces to it (badge in readme, manifest.in directive, comment in tox.ini). Can you do that? Oh and maybe add a new GH action badge to the readme?


[tox]
envlist = py27, py36, py37, py38, py39 purepy27, purepy38
envlist = py27, py36, py37, py38, py39, purepy27, purepy38, py27-no-gpg, py38-no-gpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Interesting how tox successfully builds a py39purepy27 env. :)

Github Actions is the CI now, update the README accordingly
@jku
Copy link
Collaborator Author

jku commented Feb 11, 2021

I think I finally managed to get the badge right... but we'll see once there are results for master. The PR should good to go. I can file the two issues after lunch (if you haven't at that point).

@jku jku marked this pull request as ready for review February 11, 2021 11:42
Remove coveralls badge until publishing of coverage results on
coveralls.io has been reinstated (see secure-systems-lab#325).
@lukpueh
Copy link
Member

lukpueh commented Feb 11, 2021

@jku, I added the two tickets #325 and #326, and also took the liberty to push a commit here that removes the coveralls badge (until we fix #325).

@lukpueh lukpueh merged commit bbc6afd into secure-systems-lab:master Feb 11, 2021
@jku
Copy link
Collaborator Author

jku commented Feb 11, 2021

Damn it, almost got the workflow link correct on the badge...

@lukpueh
Copy link
Member

lukpueh commented Feb 11, 2021

Damn it, almost got the workflow link correct on the badge...

Can you send a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants