-
Notifications
You must be signed in to change notification settings - Fork 54
Add Github CI workflow #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Windows gpg failures look like this And the storage test failure: |
Windows is disabled since there are multiple failures currently. The special cases (purepy27, purepy38, py27-no-gpg, py38-no-gpg) are not handled. Coveralls is not integrated.
Use the recently added GNUPG env variable to hide gpg.
lukpueh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the workflow file, @jku! It looks quite good to me. We should ticketize the remaining tasks i.e.:
- reinstate coveralls
- enable windows builds
I can do that if you want.
I also suggest to remove .travis.yml and all traces to it (badge in readme, manifest.in directive, comment in tox.ini). Can you do that? Oh and maybe add a new GH action badge to the readme?
|
|
||
| [tox] | ||
| envlist = py27, py36, py37, py38, py39 purepy27, purepy38 | ||
| envlist = py27, py36, py37, py38, py39, purepy27, purepy38, py27-no-gpg, py38-no-gpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Interesting how tox successfully builds a py39purepy27 env. :)
Github Actions is the CI now, update the README accordingly
|
I think I finally managed to get the badge right... but we'll see once there are results for master. The PR should good to go. I can file the two issues after lunch (if you haven't at that point). |
Remove coveralls badge until publishing of coverage results on coveralls.io has been reinstated (see secure-systems-lab#325).
|
Damn it, almost got the workflow link correct on the badge... |
Can you send a fix? |
Description of the changes being introduced by the pull request:
Because of recent issues with travis I ended up polishing my Github CI commit a bit: