Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSlibKey: make '_from_crypto_public_key' public API and remove 'from_pem' #678

Merged
merged 2 commits into from
Nov 28, 2023
Merged

SSlibKey: make '_from_crypto_public_key' public API and remove 'from_pem' #678

merged 2 commits into from
Nov 28, 2023

Commits on Nov 23, 2023

  1. SSlibKey: make _from_crypto_public_key public API 

    Allows more use cases, e.g. create SSlibKey
- from pyca/crypto private key (see CryptoSigner), or
- from some serialization format, supported by pyca/crypto (see
  SSlibKey.from_pem)

The commit adds tests to check if the interface correctly raises
UnsupportedLibraryError if pyca/cryptography is not installed.

Functionality is tested implicitly via SSlibKey.from_pem.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    @lukpueh
    lukpueh committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a887a29 View commit details
    Browse the repository at this point in the history

  2. SSlibKey: remove SSlibKey.from_pem 

    The more flexible SSLibKey.from_crypto can be used instead.

The additional call to pyca/crypto's "from pem" method can
easily be done in application code.

This commit updates tests and docs to use from_crypto instead.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    @lukpueh
    lukpueh committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fc4b070 View commit details
    Browse the repository at this point in the history