Skip to content

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Apr 10, 2024

  • addresses part of #731
  • blocks on #773, #774, #775 (commits are included in this PR)

close #183


The usage of the securesystemslib schema/formats facility has been little by little phased out and is now nowhere used anymore. Several reasons to not use it are listed in #183.

This patch removes schema.py along with all securesystemslib schema definitions in formats.py.

Additionally, it removes unrelated and unused helper functions in formats.py.

@lukpueh lukpueh changed the title Rm schema Remove schema facility and most of formats Apr 10, 2024
@lukpueh
Copy link
Member Author

lukpueh commented Apr 10, 2024

Some windows runners seem to calculate test coverage differently than the rest and thus drop below the already lowered constraint. I'll fix this, when this PR is no longer blocked by other PRs.

The usage of the securesystemslib schema/formats facility has been
little by little phased out and is now nowhere used anymore. Several
reasons to not use it are listed in secure-systems-lab#183.

This patch removes schema.py along with all securesystemslib schema
definitions in formats.py.

Additionally, it removes unrelated and unused helper functions in
formats.py.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh marked this pull request as ready for review April 16, 2024 09:30
@lukpueh lukpueh requested a review from jku April 16, 2024 09:31
See 8df5fcd (75 was not enough).

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh
Copy link
Member Author

lukpueh commented Apr 16, 2024

Some windows runners seem to calculate test coverage differently than the rest and thus drop below the already lowered constraint.

9be1638 further lowers the coverage requirement. As before, this does not mean that there are fewer tests (see commit message).

@jku
Copy link
Collaborator

jku commented Apr 16, 2024

this does not mean that there are fewer tests (see commit message).

Some of the bad coverage is quite expected (aws, azure, gcp, sigstore). I was surprised that HSMSigner is the worst though -- I wonder what that's about.

@lukpueh
Copy link
Member Author

lukpueh commented Apr 16, 2024

this does not mean that there are fewer tests (see commit message).

Some of the bad coverage is quite expected (aws, azure, gcp, sigstore). I was surprised that HSMSigner is the worst though -- I wonder what that's about.

elif [ "$RUNNER_OS" == "Windows" ]; then
echo "Skipping HSM tests on Windows"
# see https://github.com/secure-systems-lab/securesystemslib/issues/520

@lukpueh lukpueh merged commit 97e9117 into secure-systems-lab:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise schema and formats facility

2 participants