Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedRuntime Workflow for CI Pipeline - 301 Watermarking notebook run #1257

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

FederatedRuntime Workflow for CI Pipeline - 301 Watermarking notebook run #1257

wants to merge 33 commits into from

Conversation

noopurintel
Copy link
Contributor

@noopurintel noopurintel commented Jan 9, 2025 •
edited
Loading

  1. Added GitHub workflow "Federated Runtime 301 MNIST Watermarking" to run the notebook with same name.
  2. Enabled it to run for PR pipelines - with 5 rounds.
  3. Corrected Watermaking -> Watermarking at all relevant places.

Successful run of the workflow - https://github.com/noopurintel/openfl/actions/runs/12706219072

@noopurintel
FederatedRuntime workflow with 301 notebook run
c1c526d 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Openfl installation step
937d3c3 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Activate directly
385dece 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Tar converted file
7340c0c 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Modified
b332489 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Tar both versions
354f23b 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Temp code for testing output
8a5d61f 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Temp code for testing output
5c4285f 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Save director and envoys output to files
66b50b8 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Removed nohup
b18bf70 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Modified
12fde7c 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Use results folder
ccac00b 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Verify participant logs
c20480f 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Check if envoys are connected to director
6ee50cd 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Fail the workflow if not connected
92aa81c 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Fail the workflow if not connected
cfa27e1 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Check if participants are already present
8161113 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Corrected Watermaking to Watermarking
68bfc5c 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Remove spacing around assignment
4dceba7 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Corrected Watermaking to Watermarking
b0f32d4 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Check ports
3a52b9b 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Wait for 20s after director start
d2f30d8 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Logs inside results folder
6e70fa8 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Create results folder specifically under /home/runner
e0973dd 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Create results folder specifically under /home/runner
8da0444 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel noopurintel changed the title DO NOT REVIEW: FederatedRuntime Workflow for CI Pipeline - 301 Watermarking notebook run FederatedRuntime Workflow for CI Pipeline - 301 Watermarking notebook run Jan 10, 2025
@noopurintel noopurintel marked this pull request as ready for review January 10, 2025 06:25
@noopurintel
Use 5 rounds
ff50454 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Remove output of notebook
d386bab 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Pick the last score
fe2c61e 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Timeout 15m
0691976 
Signed-off-by: noopur <noopur@intel.com>
@noopurintel
Merge branch 'develop' into develop
e6ad920
rahulga1
rahulga1 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rahulga1 rahulga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ensure Sachin and Team review this before merging it.

@noopurintel
Interloop -> internal loop
5924913 
Signed-off-by: noopur <noopur@intel.com>
ishant162
ishant162 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ishant162 ishant162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@scngupta-dsp pls have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulga1 rahulga1 rahulga1 approved these changes

@ishant162 ishant162 ishant162 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noopurintel @ishant162 @rahulga1