Fix sarif formatting issues #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccojocar
requested changes
Feb 3, 2021
ccojocar
reviewed
Feb 3, 2021
ccojocar
approved these changes
Feb 5, 2021
Closed
kirbyquerby
added a commit
to orijtech/gosec
that referenced
this pull request
Sep 15, 2022
This change is based on securego/gosec#565 . Fixes include: * add a version field to the driver * report start and end line of issues * report correct sarif level based on the issue's reported severity rather than always warning * avoid duplicate entries in rules Updates cosmos#38
This was referenced Sep 15, 2022
kirbyquerby
added a commit
to cosmos/gosec
that referenced
this pull request
Sep 15, 2022
This change is based on securego/gosec#565 . Fixes include: * add a version field to the driver * report start and end line of issues * report correct sarif level based on the issue's reported severity rather than always warning * avoid duplicate entries in rules Updates #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #563
PR attempts to fix issues formatting issues with produced SARIF report.
Covered changes:
$schematooldeclares it's version. Used the same version as the$schema, might not be ideal but that fixes the immediate problem of invalid SARIF schema. The other option could be passing through commit SHA or gosec module version.tool'srulescouldn't be duplicatedresults'locationsarray should have only a single entry (https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317650).