Skip to content

Conversation

@JasonPowr
Copy link

@JasonPowr JasonPowr commented Sep 26, 2025

PR Type

Other


Description

  • Revert bundle build pipeline revision from branch to main

  • Update pipeline reference in Tekton configuration files


Diagram Walkthrough

flowchart LR
  A["Bundle Build Pipeline"] --> B["Revision: update-results-name-for-get-manager-image"]
  B --> C["Revision: main"]
  C --> D["Pipeline Reference Updated"]
Loading

File Walkthrough

Relevant files
Configuration changes
model-validation-operator-bundle-pull-request.yaml
Revert pipeline revision to main                                                 

.tekton/model-validation-operator-bundle-pull-request.yaml

  • Changed pipeline revision from
    update-results-name-for-get-manager-image to main
+1/-1     
model-validation-operator-bundle-push.yaml
Revert pipeline revision to main                                                 

.tekton/model-validation-operator-bundle-push.yaml

  • Changed pipeline revision from
    update-results-name-for-get-manager-image to main
+1/-1     

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Revert the bundle build pipeline to use the main branch for fetching pipeline definitions instead of a feature branch.

File-Level Changes

Change Details Files
Revert git revision for bundle build pipeline
  • Updated revision value from update-results-name-for-get-manager-image to main in the pull-request pipeline
  • Updated revision value from update-results-name-for-get-manager-image to main in the push pipeline
.tekton/model-validation-operator-bundle-pull-request.yaml
.tekton/model-validation-operator-bundle-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-merge-pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Pipeline Revision Validity

Confirm that the 'main' branch of the referenced repository contains the expected 'pipelines/bundle-build-oci-ta.yaml' path and compatible params; ensure no breaking changes compared to the previously pinned revision.

pipelineRef:
  params:
  - name: url
    value: https://github.com/securesign/pipelines.git
  - name: revision
    value: main
  - name: pathInRepo
    value: pipelines/bundle-build-oci-ta.yaml
Consistency Across Triggers

Verify both PR and push pipelines resolve to the same pipeline definition on 'main' and that required params (e.g., manager-registry-url) and serviceAccount permissions remain valid.

pipelineRef:
  params:
  - name: url
    value: https://github.com/securesign/pipelines.git
  - name: revision
    value: main
  - name: pathInRepo
    value: pipelines/bundle-build-oci-ta.yaml
  resolver: git

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@qodo-merge-pro
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Pin pipeline revision to a commit

To improve build stability and reproducibility, pin the pipeline revision to a
specific Git commit SHA or tag instead of the main branch.

.tekton/model-validation-operator-bundle-pull-request.yaml [46-47]

 - name: revision
-  value: main
+  value: <specific-git-commit-sha-or-tag>
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies a potential stability issue by using a branch reference (main) and recommends the best practice of pinning to a specific commit or tag for reproducible builds.

Medium
  • More

@JasonPowr JasonPowr merged commit 99e429b into main Sep 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant