-
Notifications
You must be signed in to change notification settings - Fork 23
Enable fips checks #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable fips checks #1420
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enables FIPS compliance by introducing a FIPS_CHECK parameter to the Tekton CI pipelines for both pull request and push workflows and updating bundle and operator CSV metadata labels to mark them as FIPS-compliant. Entity relationship diagram for updated FIPS-compliant metadata labelserDiagram
OPERATOR_BUNDLE {
string name
string fips-compliant
}
CLUSTERSERVICEVERSION {
string name
string fips-compliant
}
OPERATOR_BUNDLE ||--|| CLUSTERSERVICEVERSION : contains
OPERATOR_BUNDLE ||--|| CLUSTERSERVICEVERSION : mirrors fips-compliant
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
7d00a47 to
450dd5a
Compare
216c389 to
64e4be2
Compare
1aa9de9 to
c1581ee
Compare
c1581ee to
41811c3
Compare
|
/retest |
c98f6af to
19d2c12
Compare
19d2c12 to
387cd1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New security issues found
| LocalObjectReference: v1alpha1.LocalObjectReference{ | ||
| Name: "my-invalid-tuf-keys", | ||
| }, | ||
| Key: "fulcio_v1.crt.pem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Source: gitleaks
| LocalObjectReference: v1alpha1.LocalObjectReference{ | ||
| Name: "my-tuf-keys", | ||
| }, | ||
| Key: "fulcio_v1.crt.pem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Source: gitleaks
| LocalObjectReference: v1alpha1.LocalObjectReference{ | ||
| Name: "my-invalid-tuf-cert", | ||
| }, | ||
| Key: "fulcio_v1.crt.pem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Source: gitleaks
| LocalObjectReference: v1alpha1.LocalObjectReference{ | ||
| Name: "my-tuf-cert", | ||
| }, | ||
| Key: "fulcio_v1.crt.pem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Source: gitleaks
Summary by Sourcery
Enable FIPS checks in CI pipelines and mark the operator as FIPS-compliant
Enhancements:
fips-checkparameter set to true across operator and bundle Tekton pipeline definitions for pull-request and push workflows