Skip to content

Conversation

@JasonPowr
Copy link
Member

@JasonPowr JasonPowr commented Nov 3, 2025

Summary by Sourcery

Enable FIPS checks in CI pipelines and mark the operator as FIPS-compliant

Enhancements:

  • Add fips-check parameter set to true across operator and bundle Tekton pipeline definitions for pull-request and push workflows
  • Update bundle Dockerfile and ClusterServiceVersion manifest to label the operator as FIPS-compliant

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables FIPS compliance by introducing a FIPS_CHECK parameter to the Tekton CI pipelines for both pull request and push workflows and updating bundle and operator CSV metadata labels to mark them as FIPS-compliant.

Entity relationship diagram for updated FIPS-compliant metadata labels

erDiagram
  OPERATOR_BUNDLE {
    string name
    string fips-compliant
  }
  CLUSTERSERVICEVERSION {
    string name
    string fips-compliant
  }
  OPERATOR_BUNDLE ||--|| CLUSTERSERVICEVERSION : contains
  OPERATOR_BUNDLE ||--|| CLUSTERSERVICEVERSION : mirrors fips-compliant
Loading

File-Level Changes

Change Details Files
Enable FIPS check in CI pipelines
  • Add a fips-check parameter with value "true" to pull-request bundle pipeline
  • Add a fips-check parameter with value "true" to push bundle pipeline
  • Add a fips-check parameter with value "true" to pull-request operator pipeline
  • Add a fips-check parameter with value "true" to push operator pipeline
.tekton/rhtas-operator-bundle-pull-request.yaml
.tekton/rhtas-operator-bundle-push.yaml
.tekton/rhtas-operator-pull-request.yaml
.tekton/rhtas-operator-push.yaml
Mark bundle as FIPS-compliant
  • Change features.operators.openshift.io/fips-compliant label to "true"
bundle.Dockerfile
Mark operator CSV as FIPS-compliant
  • Update clusterserviceversion annotation features.operators.openshift.io/fips-compliant to "true"
config/manifests/bases/rhtas-operator.clusterserviceversion.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JasonPowr JasonPowr changed the title ci: enable fips checks Enable fips checks Nov 3, 2025
@JasonPowr JasonPowr force-pushed the fips-compliance-test branch 4 times, most recently from 7d00a47 to 450dd5a Compare November 6, 2025 13:49
@osmman osmman added the test label Nov 6, 2025
@JasonPowr JasonPowr force-pushed the fips-compliance-test branch 6 times, most recently from 216c389 to 64e4be2 Compare November 14, 2025 14:02
@JasonPowr JasonPowr force-pushed the fips-compliance-test branch 5 times, most recently from 1aa9de9 to c1581ee Compare November 21, 2025 09:06
@JasonPowr JasonPowr force-pushed the fips-compliance-test branch from c1581ee to 41811c3 Compare November 25, 2025 15:55
@JasonPowr
Copy link
Member Author

/retest

@JasonPowr JasonPowr force-pushed the fips-compliance-test branch 6 times, most recently from c98f6af to 19d2c12 Compare December 1, 2025 10:57
@JasonPowr JasonPowr force-pushed the fips-compliance-test branch from 19d2c12 to 387cd1d Compare December 2, 2025 15:28
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

LocalObjectReference: v1alpha1.LocalObjectReference{
Name: "my-invalid-tuf-keys",
},
Key: "fulcio_v1.crt.pem",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

Source: gitleaks

LocalObjectReference: v1alpha1.LocalObjectReference{
Name: "my-tuf-keys",
},
Key: "fulcio_v1.crt.pem",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

Source: gitleaks

LocalObjectReference: v1alpha1.LocalObjectReference{
Name: "my-invalid-tuf-cert",
},
Key: "fulcio_v1.crt.pem",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

Source: gitleaks

LocalObjectReference: v1alpha1.LocalObjectReference{
Name: "my-tuf-cert",
},
Key: "fulcio_v1.crt.pem",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (generic-api-key): Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

Source: gitleaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants