Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Use deployment to verify configuration update of component #522

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Jul 23, 2024

No description provided.

Copy link

openshift-ci bot commented Jul 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@osmman osmman force-pushed the tturek/fix-config-update-test branch from 81af40c to 17d8b1b Compare July 23, 2024 09:14
@osmman osmman force-pushed the tturek/fix-config-update-test branch from 17d8b1b to 61fb6f8 Compare July 23, 2024 09:59
@osmman osmman marked this pull request as ready for review July 23, 2024 10:40
@openshift-ci openshift-ci bot requested review from sallyom and tommyd450 July 23, 2024 10:40
@osmman osmman requested review from JasonPowr and removed request for sallyom July 23, 2024 11:57
Copy link
Contributor

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5fdbe66 into main Jul 23, 2024
11 checks passed
@osmman osmman deleted the tturek/fix-config-update-test branch September 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants