fix(ctlog): cleanup only linked server configs #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osmman
force-pushed
the
tturek/ctlog-server-config
branch
from
a8245ba
to
b85d6e3
Compare
osmman
force-pushed
the
tturek/ctlog-server-config
branch
from
b85d6e3
to
863bc93
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of cleanup of ServerConfig secrets and invalidation mechanism
Handling of Deleted Generated Secrets:
In cases where generated secrets were being deleted due to duplicate events during the operator's reconciliation process, I have adjusted order of execution. Now, any secrets that have the expected resource labels will be removed after successful creation of new one.
ServerConfig Invalidation Mechanism:
I have modified the mechanism that invalidates the current server configuration in response to external actions, such as the creation of a Trillian tree, issuance of Fulcio certificates, or the generation of signer keys. When any of these external actions result in a change of data, the ServerConfigAvaliable status is now correctly set to
false. This triggers the necessary reconciliation to maintain the correct state of the server configuration.