Skip to content

Conversation

@JasonPowr
Copy link
Member

@JasonPowr JasonPowr commented Oct 31, 2025

Summary by Sourcery

Include a FIPS compliance check in CI by enabling the fips-check flag across all relevant Tekton pipeline configurations

CI:

  • Add fips-check parameter set to true in fetch-tsa-certs pull-request pipeline
  • Add fips-check parameter set to true in fetch-tsa-certs push pipeline
  • Add fips-check parameter set to true in timestamp-authority pull-request pipeline
  • Add fips-check parameter set to true in timestamp-authority push pipeline

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 31, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces and enables a new FIPS compliance validation step by injecting a “fips-check” parameter into four existing Tekton pipeline definitions.

File-Level Changes

Change Details Files
Enable FIPS compliance check in fetch-tsa-certs pipelines
  • Insert fips-check parameter set to "true" after go test in pull-request pipeline
  • Insert fips-check parameter set to "true" after go test in push pipeline
.tekton/fetch-tsa-certs-pull-request.yaml
.tekton/fetch-tsa-certs-push.yaml
Enable FIPS compliance check in timestamp-authority pipelines
  • Insert fips-check parameter set to "true" after go test in pull-request pipeline
  • Insert fips-check parameter set to "true" after go test in push pipeline
.tekton/timestamp-authority-pull-request.yaml
.tekton/timestamp-authority-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The fips-check parameter is added without a params: wrapper, so it should be nested under spec.params to produce valid Tekton YAML.
  • Since you’re adding the same fips-check parameter to multiple pipeline files, consider extracting it into a shared template or common include to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The fips-check parameter is added without a params: wrapper, so it should be nested under spec.params to produce valid Tekton YAML.
- Since you’re adding the same fips-check parameter to multiple pipeline files, consider extracting it into a shared template or common include to reduce duplication.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JasonPowr JasonPowr marked this pull request as draft October 31, 2025 14:25
@JasonPowr JasonPowr force-pushed the add-fips-check branch 3 times, most recently from 5d4e12f to ee40dec Compare October 31, 2025 16:23
@JasonPowr
Copy link
Member Author

/retest

Signed-off-by: Jason Power <japower@redhat.com>
@JasonPowr
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant