Merge release 3.4.2 from pilot branch to master branch #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the pilot branch the same as master
merge master into pilot
Update pilot CHANGELOG from master
- updated Dockerfile-dalton - emptied out the requirements.txt file
Use pyproject.toml (#184)
Run ruff format to standardize file formatting
- there are 22 items to fix manually.
Ran ruff check --fix to fix style issues automatically
- updated the changelog
Added github CI workflow
- small refactoring inside dalton.py and flowsynth.py - initialize logging at init time not import time - check for rulesets at init time not import time - added some basic tests
unit tests can run
- these fixes all were done by ruff - I used `ruff format` and `ruff check --fix --unsafe-fixes` - Some manual fixes still are needed
Also lint dalton agent
- Added a Makefile target to lint the Dockerfiles - The default nginx docker image has a CMD of ["nginx" "-g" "daemon off;"] so - we don't need the CMD in our Dockerfile - and we can't have "daemon off" in our nginx config
Update nginx
- do not send a NoneType or a boolean False to redis-py
Update redis from 3.2 to 7.4
- Small refactoring - Small tweaks to comments - Update Makefile - Properly show any flowsynth errors
Add unit tests for the flowsynth web UI
Use ruff to sort imports
- ruff found a couple of good fixes - added a unit test for dalton
Additional code checking by ruff
- slight tweaks to the Dockerfiles - ran hadolint
Use pre-built zeek images
- Added two makefile targets for bumping the version.
Use bump-my-version tool to help with versioning
- since the redis update in #205
job results boolean bug with zeek and json
- zeek_json contains the data or "False"
Zeek results were not being shown
- eliminate the redis global variable 'r' - remove other usages of the 'global' keyword - added github workflow for hadolint
Add unit tests for dalton app
Bump version: 3.4.0 → 3.4.1
- remove unused or unuseful dependencies
- added changelog entry - start the flask app with the `flask` command line tool
Update flask dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Pull requests: