Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react and react-dom from npm dependencies #279

Closed
wavto opened this issue Oct 4, 2017 · 2 comments
Closed

remove react and react-dom from npm dependencies #279

wavto opened this issue Oct 4, 2017 · 2 comments

Comments

@wavto
Copy link

wavto commented Oct 4, 2017

Hi

React should generally never be directly listed in the dependencies of a package, instead it should be within the peerDependencies.

This package had that correct until commit 0ef6c18 a couple of days ago.

Please remove react and react-dom from the dependencies of this project.

Thank you

@M-ZubairAhmed
Copy link

Hi,
currently in peer dependency react and react-dom versions are 15.0.1 while the ones in dependencies the version is 15.6.2. Should i also add that version in peer too?

@wavto
Copy link
Author

wavto commented Oct 4, 2017

Hi @M-ZubairAhmed

Thank your for picking up my issue.

With the SemVer definition ^15.0.1 NPM will automatically take the newest 15.xx version, therefore it doesn't really matter.

ohtake added a commit to FujitsuLaboratories/cattaz that referenced this issue Nov 13, 2017
Skips react-ace 5.2.2 because it has incorrect dependencies.
See <securingsincity/react-ace#279>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants