Add peer heartbeat monitor #36 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkamonMdt this looks great!! |
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
mkamonMdt
force-pushed
the
36-remove-disconnected-user-canvas
branch
from
bf63a09 to
91fe84c
Compare
darioalessandro
approved these changes
Jun 5, 2024
|
Pending testing |
mkamonMdt
added a commit
to mkamonMdt/videocall-rs
that referenced
this pull request
Jun 24, 2024
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
mkamonMdt
added a commit
to mkamonMdt/videocall-rs
that referenced
this pull request
Jun 27, 2024
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
mkamonMdt
added a commit
to mkamonMdt/videocall-rs
that referenced
this pull request
Jun 27, 2024
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
mkamonMdt
added a commit
to mkamonMdt/videocall-rs
that referenced
this pull request
Jun 27, 2024
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
darioalessandro
added a commit
that referenced
this pull request
Jul 4, 2024
* Max 20 canvases on screen: The PeerList The commit introduces struct component PeerList which is to resposible for active Peer management. At current stage, the PeerList should expand and collapse, claiming dedicated screen chunk, accept (hardcoded at the moment) list of Peers and enable basic filterming function. * Max 20 canvases on screen: extract Canvas generator In preparation to limit Canvases, the commit extracts a function responsible for thier preparation given vector of peer indetifiers. No changes in canvas preparation logic were introduced. * Max 20 canvases on screen: Setup canvas limit The canvas number is limited up to 20. The limit criteria is simple alphabetical order. All peers can be seen in the PeerList. * Max 20 canvases on screen: PeerList refinement The commit turns raw-text PeerList into scrollable list of PeerListItems, a struct component that might be further developed with functional features. * Add peer heartbeat monitor (#157) The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer. * Update README.md (#159) * updating base images (#160) * updating base images * update base image * cache build * fmt * make ci green again * pass linter --------- Co-authored-by: Dario A Lencina-Talarico <darioalessandrolencina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period.
The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.