Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not allow stake amounts to be zero #259

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

gluax
Copy link
Collaborator

@gluax gluax commented Feb 3, 2025

Motivation

To not allow stake to be zero since it breaks behavior.

Explanation of Changes

Disallow both stake fields from being zero.

Testing

Two new tests.

Related PRs and Issues

N/A

@gluax gluax self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Code Coverage

Package Line Rate Complexity Health
contract.src.msgs.data_requests.state 98% 0
contract.src.msgs.data_requests 97% 0
contract.src 86% 0
contract.src.msgs.data_requests.sudo 92% 0
contract.src.msgs.owner.execute 96% 0
contract.src.msgs.owner 100% 0
contract.src.msgs.staking.execute 97% 0
contract.src.msgs.staking 96% 0
contract.src.msgs.staking.state 96% 0
contract.src.msgs 93% 0
contract.src.msgs.data_requests.execute 100% 0
Summary 96% (3970 / 4121) 0

@gluax gluax merged commit a101937 into main Feb 3, 2025
2 checks passed
@gluax gluax deleted the fix/disallow-zero-minimum-stake branch February 3, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants