Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no longer return empty drs when paused #261

Merged
merged 2 commits into from
Feb 6, 2025
Merged

chore: no longer return empty drs when paused #261

merged 2 commits into from
Feb 6, 2025

Conversation

FranklinWaller
Copy link
Member

Since we now always continue the flow and that way tally can always resolve

Thomasvdam
Thomasvdam previously requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Thomasvdam Thomasvdam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, all the sudo methods are still paused 😬

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Code Coverage

Package Line Rate Complexity Health
contract.src.msgs.staking.execute 97% 0 ✔
contract.src.msgs.data_requests 97% 0 ✔
contract.src 86% 0 ✔
contract.src.msgs.owner.execute 96% 0 ✔
contract.src.msgs.data_requests.sudo 92% 0 ✔
contract.src.msgs.owner 100% 0 ✔
contract.src.msgs.staking 96% 0 ✔
contract.src.msgs.staking.state 96% 0 ✔
contract.src.msgs.data_requests.execute 100% 0 ✔
contract.src.msgs.data_requests.state 98% 0 ✔
contract.src.msgs 93% 0 ✔
Summary 96% (4008 / 4159) 0 ✔

@gluax gluax requested a review from Thomasvdam February 6, 2025 15:31
@gluax gluax merged commit 7e1f3da into main Feb 6, 2025
2 checks passed
@gluax gluax deleted the feat/no-more-empty-drs branch February 6, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocao mariocao mariocao approved these changes

@Thomasvdam Thomasvdam Awaiting requested review from Thomasvdam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FranklinWaller @Thomasvdam @mariocao @gluax