Require secp256k1 pubkey registration for unjail #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
We override the slashing module's unjail transaction to add an additional check for registration of required SEDA public keys.
Testing
Tested on a 4-node local network where one of the nodes was missing the required public key. When the proving scheme was activated, the node was jailed. Subsequently, its unjail attempts were blocked until it registered the required public key.
Note there is a bug where the keyring directory doesn't default to the home directory given by the
--home
flag, so the--keyring-dir
flag has to be provided. Created issue #435Related PRs and Issues
Closes: #422