refactor: Remove data results from post result sudo msg

[hacheigriega]

Motivation

Removing data results fields from the PostResult sudo message since the contract no longer needs them. This chain repo implements a data results store on the chain side instead: sedaprotocol/seda-chain#357

[gluax]

Do we even need this message anymore? Or is it just so the chain notifies the contract to remove them from the data request pool? Do we still need a query to get a data result from the contract?

[hacheigriega]

Do we even need this message anymore? Or is it just so the chain notifies the contract to remove them from the data request pool? Do we still need a query to get a data result from the contract?

Right it would be just so that the contract can remove the items from the data request pool.

And good point that data results would have to be queried on the chain side instead. I removed the query here.

[gluax]

Got it. Let me help with fixing the failing CI stuff, but I would like to wait to merge this till we make the changes in other affected places and can test it with the test suite or something. Or maybe I'm being too paranoid, but let's see what others think?

[hacheigriega]

Got it. Let me help with fixing the failing CI stuff, but I would like to wait to merge this till we make the changes in other affected places and can test it with the test suite or something. Or maybe I'm being too paranoid, but let's see what others think?

Yes for sure and thanks. I thought I could handle Rust..

[gluax]

No one handles rust, rust handles you 😆

[hacheigriega]

No one handles rust, rust handles you 😆

I also got stuck while making corresponding changes in the contract. It's probably much quicker that you just take care of it.. I think the module should just take care of hashing data results and emitting events about them. Initially I was hoping to get the data result hash as a return value of the sudo call, but I don't think this is possible.

[gluax]

No one handles rust, rust handles you 😆

I also got stuck while making corresponding changes in the contract. It's probably much quicker that you just take care of it.. I think the module should just take care of hashing data results and emitting events about them. Initially I was hoping to get the data result hash as a return value of the sudo call, but I don't think this is possible.

Hm, yeah, we'd need to match the hashing that was done here on the go side, but that should be fine. The contract could do the hashing, but it would require not changing the Sudo method as it would still need the result to do the hash.

I can make the corresponding changes on the other sides, I'll focus on that tomorrow if that's ok!

[hacheigriega]

Hm, yeah, we'd need to match the hashing that was done here on the go side, but that should be fine. The contract could do the hashing, but it would require not changing the Sudo method as it would still need the result to do the hash.

I can make the corresponding changes on the other sides, I'll focus on that tomorrow if that's ok!

Sounds good! And I am working on the chain side.

[Thomasvdam]

Lgtm