fix: memo staking verification #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
So that memos don't break staking.
Explanation of Changes
So the memo was being used, but the problem is the types were different in cosmwasm(Binary) vs non-cosmwasm(String).
Since they were options, the
.hash()method usesAsRef<[u8]>which was different for each type.Now we handle the memo in the
Stakingmessage the same way we do for thePostDataRequestArgs.This is a breaking change in the API, so it's a minor version increment.
Testing
Added a new test for testing that the non-cosmwasm side correctly generates a proof, and the cosmwasm side verifies the proof.
Related PRs and Issues
We should create a new issue to add this test for any of the proof & verification. To ensure bugs similar to this one are caught right away.