Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: max bytes #40

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat: max bytes #40

merged 3 commits into from
Dec 2, 2024

Conversation

gluax
Copy link
Collaborator

@gluax gluax commented Dec 2, 2024

Motivation

To limit bytes for execution result.

Explanation of Changes

Same changes from overlay.
Plus bump version.

Testing

Tests pass.

Related PRs and Issues

Someone please update mac lib before we merge :).

Closes #34.

@gluax gluax self-assigned this Dec 2, 2024
@gluax gluax mentioned this pull request Dec 2, 2024
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good to add a test tally binary that writes a huge result?

@gluax
Copy link
Collaborator Author

gluax commented Dec 2, 2024

Maybe good to add a test tally binary that writes a huge result?

Do we have one handy? I don't think we have a test for that on the overlay side either as far as I can tell.

@gluax gluax marked this pull request as ready for review December 2, 2024 15:31
@Thomasvdam
Copy link
Member

Maybe good to add a test tally binary that writes a huge result?

Do we have one handy? I don't think we have a test for that on the overlay side either as far as I can tell.

In that case lets create an issue for that and do it later ™️

@Thomasvdam Thomasvdam force-pushed the feat/exec-max-bytes branch 2 times, most recently from 90d52e9 to dc1a991 Compare December 2, 2024 15:54
Base automatically changed from feat/return-gas-used to main December 2, 2024 15:57
@gluax gluax merged commit 6f77c51 into main Dec 2, 2024
4 checks passed
@gluax gluax deleted the feat/exec-max-bytes branch December 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 execution_result must have a maximum amount of allowed bytes as output
2 participants