Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeries Support #1

Merged
merged 5 commits into from
Aug 30, 2024
Merged

TimeSeries Support #1

merged 5 commits into from
Aug 30, 2024

Conversation

sfalkena
Copy link
Collaborator

@sfalkena sfalkena commented Aug 27, 2024

Updating samplers by:

  • Pre-calculating all chips for all samplers, now we can also save the chips of random sampler for inspection.
  • Moving utilities such as filtering, worker split to GeoSampler, so that every sampler can use this.
  • Adding return_as_sits to GeoDataset, so every dataset supports this attribute.
  • Set return_as_sits for IntersectionDataset and UnionDataset.
  • Fix tests that are failing now
  • Add tests for added functionality

Todo:

  • Add train_val split function to GeoSampler

@sfalkena sfalkena marked this pull request as ready for review August 28, 2024 14:16
Copy link

@borobaya borobaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


@abc.abstractmethod
def get_chips(self, *args: Any, **kwargs: Any) -> GeoDataFrame:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Body of the function missing or is this simply a placeholder?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an abstract method, so all classes implementing GeoSampler should define a function called get_chips. Python automatically raises an error if your class does not have a get_chips function

@sfalkena sfalkena merged commit fedca36 into main Aug 30, 2024
2 of 4 checks passed
@sfalkena sfalkena deleted the ts_support branch August 30, 2024 09:58
@sfalkena sfalkena restored the ts_support branch September 17, 2024 08:47
@sfalkena sfalkena deleted the ts_support branch September 20, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants