-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write scalars as scalars and not as lists #76
Conversation
I think they are grouped as period values, or not? |
No its about single scalars like efficiencies which are constant. These would be translated in tabular to timeseries if necessary. But currently they would end up as list of lists on tabular and not as a list of values as they are in the datapackage as a list of one single value. |
If lists are found that do not match timeseries lengths they stay as they are because we cant actually know what those values are. |
Regardless of the origin of this problem, I am pretty certain that a list of an iterable with length 1 eg. [[1,]] or [(1,)] is for no use. In my situation, data is uploaded to oep for each year as
I currently need this, once the uploaded data is flawless, this could be removed again. |
I think the type |
I talked to Hedda. New data will take some time to be uploaded. I need this to go on with bev-development. I will therefore merge this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good workaround!
I agree for merging it, as I cannot see that new data will be there in time...
In my current AP8 dataset I use, scalars are returns as list of scalar and also passed as list of scalars to tabular. which doesnt work.
this is a fix. I am not sure if this is actually necesary as @henhuy maybe already takes care of this in data_adapter