-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/handle nans #89
Conversation
outdated due to using struct from excel sheet
due to future warning for pandas depreciating unique function for lists
…' into feature/extend_steel_example # Conflicts: # examples/industry/data_adapter_industry.py
…' into feature/extend_steel_example # Conflicts: # poetry.lock
Now handeling also other columns than min/max
Now handeling also other columns than min/max
…dapter_oemof into feature/handle_nans
Added functionality to find and replace irrelevant Searches for where investment is allowed
If no Investment is allowed and there have been periods with investment before ("decommissioning of investment") this may lead to issues since capacity might still be existing and values will be assigned as they were not intended. If the user wants to use specific data here they should provide it (: Searches for decomissioned Processes
Moreover moved replacement of min/max values from #78 to seperate function More documentation has been written in code docstrings. |
data_adapter_oemof/calculations.py
Outdated
] | ||
# no investment in decommissioning processes | ||
# no capacity can be set on investment objects | ||
if not any([x in capacity_columns for x in group_df.columns]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly asking for opinion on if/else statement since it actually is not needed.
I added it because data where capacity is set and investment is allowed at the same time the nans cannot be handled by the developed logic so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not understand all - left some comments.
Thx for implementing though!
Adapted to use pd.DataFrame.where in stead to fill in nans. |
Handlling Nans is crucial for data_adapter_oemof to work.
Some data might be missing due to
irrelevance
this data still has to be filled since oemof.solph multi period cannot take cahnging values includingNone
and fill with defaults. Therefore the Nan handler is necessary.Continue work from #78