Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak bootstrap order so that main_el_vdom is initialized first. #274

Merged
merged 3 commits into from
Nov 1, 2019

Conversation

AlterionX
Copy link
Contributor

Part of #235.

Forces process_cmd_and_msg_queue to occur after the main_el_vdom is initialized, making it consistent with all other calls of process_cmd_and_msg_queue.

Also removes an extra Node wrapping for calling assign_ws_nodes_to_el when bootstrapping the vdom.

@AlterionX AlterionX changed the title Tweak bootstrap order so that main_el_vdom is initialized. Tweak bootstrap order so that main_el_vdom is initialized first. Oct 30, 2019
src/vdom.rs Outdated Show resolved Hide resolved
@David-OConnor David-OConnor merged commit 179e11d into seed-rs:master Nov 1, 2019
@David-OConnor
Copy link
Member

David-OConnor commented Nov 1, 2019

@AlterionX : Does this wrap up this set of PRs? If not, of you think of something later, we can always add more.

@AlterionX
Copy link
Contributor Author

AlterionX commented Nov 2, 2019

@David-OConnor There's one more piece. Almost done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants