Add parameter for specifying what to do with elements that already exist within the mount. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to denote what to do with children that already exist in the mount element when mounting.
|
I'll close #235 after this gets merged. |
MartinKavik
reviewed
Nov 2, 2019
MartinKavik
reviewed
Nov 2, 2019
MartinKavik
reviewed
Nov 2, 2019
|
I tested it with a project based on webpack quickstart with and without prerendering and everything seems to work. Good job. I think we can merge it once the review comments are resolved. |
|
I'll fix the mentioned issues soon. |
MartinKavik
reviewed
Nov 3, 2019
|
Adding this to the guide. |
MartinKavik
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last part of #235.
takeover_mountinAppBuilder). Due to this behavior and backwards compatibility, it is currently an opt in functionality.