refactor: ♻️ use check functions in edit_package_properties
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
…checks-2-simple-helper-functions
…/sprout-checks-3-required-and-blank-checks
…at/sprout-checks-4-sprout-specific-package-and-resource-errors
…ce-errors' into feat/sprout-checks-5-check-resource-properties
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
…at/sprout-checks-6-check-package-properties
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
…t/sprout-checks-7-check-properties
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
…eck-error-matcher
3 tasks
martonvago
commented
Jan 22, 2025
Comment on lines
+68
to
+71
| check_properties( | ||
| current_properties, | ||
| ignore=[CheckErrorMatcher(validator="required", json_path="resources")], | ||
| ) |
There was a problem hiding this comment.
Required check done because at this point all required fields should be present -- that is, all required fields except resources.
However, as above, resources may be present (if they were on the original properties), so I'm using check_properties for a full check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
edit_package_propertiesto use the check functions.Once #976 is merged in, I will update this PR with those changes. <-- Done! ✔️
This PR needs an in-depth review.
Checklist
just run-all