-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON columns parsing with SQLite client #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogama
force-pushed
the
feature/parse-on-fetch-with-sqlite
branch
18 times, most recently
from
June 6, 2016 12:36
3807cf2
to
a6df677
Compare
ricardogama
force-pushed
the
feature/parse-on-fetch-with-sqlite
branch
from
June 6, 2016 12:43
a6df677
to
828d9a9
Compare
ricardogama
force-pushed
the
feature/parse-on-fetch-with-sqlite
branch
from
June 6, 2016 12:52
828d9a9
to
842c077
Compare
ricardogama
force-pushed
the
feature/parse-on-fetch-with-sqlite
branch
2 times, most recently
from
June 6, 2016 19:16
6d8fc1a
to
832b42d
Compare
import knexfile from './knexfile'; | ||
import should from 'should'; | ||
import sinon from 'sinon'; | ||
import { dropTable, recreateTable } from '../utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort.
await dropTable(repository); | ||
}); | ||
|
||
describe('if a json column is not registered', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
ricardogama
force-pushed
the
feature/parse-on-fetch-with-sqlite
branch
from
June 7, 2016 15:03
832b42d
to
e04ed76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SQLite, parsing JSON columns on fetch.
Closes #16